Open
Conversation
Fixing multiple calls to result, when getAccount is called Re-organized files Changed pubspec.yaml to latest format
Modified .gitignore
Adding lock file to repo
Bugfix/multiple calls
Needed to pull dependencies of MSAL library.
Bumping to the next major version since this includes a breaking change.
gbwisx
reviewed
Dec 12, 2020
Owner
gbwisx
left a comment
gbwisx
left a comment
There was a problem hiding this comment.
This looks good. I added some documentation for some of the changes you made and bumped the version to 1.0. My only suggestion was to merge the acquireToken and acquireTokenWithLoginHint functions together by just adding a loginHint optional param to acquireToken.
| if (!silentResult.isSuccess && silentResult.isUiRequired) { | ||
|
|
||
| Map<String, dynamic> params = {'scopes': scopes}; | ||
| if(loginHint != null){ |
Owner
There was a problem hiding this comment.
Can this condition just be added to the acquireToken function? You should be able to just add a third optional parameter of loginHint to the signature instead of creating a new mostly redundant function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.