allow config files from outside the bundle#7
Open
BAndonovski wants to merge 3 commits intogbwisx:masterfrom
Open
allow config files from outside the bundle#7BAndonovski wants to merge 3 commits intogbwisx:masterfrom
BAndonovski wants to merge 3 commits intogbwisx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use case leading to this PR:
The config file needs to be downloaded from remote and used. It can be (and often is) changed, so it cannot be cached, or embedded into the bundle.
So, instead of using a cache, use a file from the system directly.
The code needs to be cleaned up, of course, once we discuss / agree on the idea, will do that.