forked from postgres/postgres
-
Notifications
You must be signed in to change notification settings - Fork 0
prune the heap more #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gburd
wants to merge
6
commits into
master
Choose a base branch
from
heap-prune-freq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,796
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c88af1a to
7526314
Compare
7526314 to
4d84c48
Compare
Exercise the existing heapam page pruning code on the INSERT paths to more pro-actively re-order heap pages and potentially free up space.
heap_page_prune_opt() doesn't take into account the size of the tuple that's trying to be inserted, it only checks if the page has less free space than the minimum threshold, but doesn't consider whether pruning could make enough space for a specific tuple. Consider pruning if the current free space plus potential space from pruning could accommodate the tuple, even if the page doesn't meet the normal threshold.
Add scan-time heap page pruning functionality and a mechanism to track page modifications during scans and re-evaluate pruning eligibility. This addresses the issue where multiple updates during a scan don't trigger heap page pruning until the next scan.
Set PageSetPrunable during heap_insert() and heap_multi_insert() to enable opportunistic cleanup of dead tuples from aborted transactions. Previously, aborted insert tuples would remain until the next vacuum cycle if no other modifications occurred on the page.
4d84c48 to
2284b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.