Skip to content

Entrega ejercicios 1 y 2#7

Open
matingb wants to merge 9 commits intogbobr:masterfrom
matingb:master
Open

Entrega ejercicios 1 y 2#7
matingb wants to merge 9 commits intogbobr:masterfrom
matingb:master

Conversation

@matingb
Copy link

@matingb matingb commented Oct 5, 2018

No description provided.

@gbobr
Copy link
Owner

gbobr commented Oct 12, 2018

run tests

@gbobr
Copy link
Owner

gbobr commented Oct 12, 2018

Can one of the admins verify this patch?

Copy link
Owner

@gbobr gbobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ejercicio 1 correcto.
Ejercicio 2 falla compilación con error:

  • cd ejercicio2
  • make test
    gcc -g -Wall -c main.c -o main.o
    main.c: In function ‘main’:
    main.c:11:5: warning: ‘gets’ is deprecated (declared at /usr/include/stdio.h:638) [-Wdeprecated-declarations]
    gets(cadena);
    ^
    main.c:23:9: warning: statement with no effect [-Wunused-value]
    for(p; *p != 0; p++)
    ^
    main.c:42:9: warning: implicit declaration of function ‘getch’ [-Wimplicit-function-declaration]
    getch();
    ^
    main.c:7:9: warning: unused variable ‘i’ [-Wunused-variable]
    int i;
    ^
    gcc main.o -Wall -lm -o ejercicio2
    main.o: In function main': /var/lib/jenkins/jobs/punteros2/workspace/ejercicio2/main.c:11: warning: the gets' function is dangerous and should not be used.
    /var/lib/jenkins/jobs/punteros2/workspace/ejercicio2/main.c:42: undefined reference to `getch'
    collect2: error: ld returned 1 exit status
    make: *** [ejercicio2] Error 1

@gbobr
Copy link
Owner

gbobr commented Oct 18, 2018

add to whitelist

@gbobr
Copy link
Owner

gbobr commented Oct 18, 2018

Falla el test del ejercicio 2, aparentemente el formato de la salida no coincide exactamente con el esperado.
Ver la salida en: https://jenkins-gbobr-ci.7e14.starter-us-west-2.openshiftapps.com/job/punteros2/30/console

@gbobr
Copy link
Owner

gbobr commented Oct 25, 2018

Revisar la salida del ejercicio 3, no coinciden los id que se están imprimiendo:

< 3, Juan, 150
< 1, Nevermore, 100
< 0, Berserker, 97
< 2, r4t0, 71
---
> 4, Juan, 150
> 2, Nevermore, 100
> 1, Berserker, 97
> 3, r4t0, 71

Ver más detalles en: https://jenkins-gbobr-ci.7e14.starter-us-west-2.openshiftapps.com/job/punteros2/39/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants