Open
Conversation
Immediate connect via an upfront subscription to kick off the handshake instantly. 5 s auto-reconnect on both errors and clean closes, so if the server goes down and comes back up OS-DPI should be able to auto connect back to it without the need to refresh the page
Gives location of the device- browser based
location tracker
location tracker added
location tracker added
Owner
|
Did you eliminate the ability to fetch an image over the socket? No longer needed on your end? I think it was added at your request. |
Owner
|
In socketHandler.js I notice that retryWhen and repeatWhen are deprecated. |
Owner
|
In components/actions.js Globals.locationTracker is not defined. |
Owner
|
In actions.js you deleted the merge method? |
Owner
|
In components/locationTracker.js 154 to 156 the parameters should be strings. |
Owner
|
In start.js I see there are references to Globals.method but it should be methods. Maybe you based this pull request on an earlier version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the behavior of the socket's lazy subscription,
Added another component to track location of the device through browser based gps
you can start and stop the location tracking through
$locationTrackingstate, just set it totrue/1orfalse/0to start and stop.