Skip to content

Fix wrong OR to AND in BUILD_TESTING and PROJECT_IS_TOP_LEVEL logic #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traversaro merged 2 commits into from
Apr 7, 2025
Merged

Fix wrong OR to AND in BUILD_TESTING and PROJECT_IS_TOP_LEVEL logic #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e94776
Fix wrong OR to AND in BUILD_TESTING and PROJECT_IS_TOP_LEVEL logic
traversaro Apr 7, 2025
ff750c2
Release 1.3.3
traversaro Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,6 @@ include(CTest)
# or if serial_cpp_FORCE_RESPECT_BUILD_TESTING is ON, so if you include the project
# via FetchContent or add_subdirectory and if you want to compile tests, you
# need to set both BUILD_TESTING and serial_cpp_FORCE_RESPECT_BUILD_TESTING to ON
if(BUILD_TESTING OR (PROJECT_IS_TOP_LEVEL OR serial_cpp_FORCE_RESPECT_BUILD_TESTING))
if(BUILD_TESTING AND (PROJECT_IS_TOP_LEVEL OR serial_cpp_FORCE_RESPECT_BUILD_TESTING))
add_subdirectory(tests)
endif()
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ include(FetchContent)
FetchContent_Declare(
serial_cpp
GIT_REPOSITORY https://github.com/ami-iit/serial_cpp.git
GIT_TAG v1.3.2 # or use the tag or commit you prefer
GIT_TAG v1.3.3 # or use the tag or commit you prefer
)

FetchContent_MakeAvailable(serial_cpp)
Expand Down
2 changes: 1 addition & 1 deletion package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<package>
<name>serial_cpp</name>
<version>1.3.2</version>
<version>1.3.3</version>
<description>
serial_cpp is a cross-platform, simple to use library for using serial ports on computers.
This library provides a C++, object oriented interface for interacting with RS-232
Expand Down
Loading