Factor out common functions for reading integers of all bases#1888
Open
Rangi42 wants to merge 1 commit intogbdev:masterfrom
Open
Factor out common functions for reading integers of all bases#1888Rangi42 wants to merge 1 commit intogbdev:masterfrom
Rangi42 wants to merge 1 commit intogbdev:masterfrom
Conversation
Rangi42
added
rgbasm
Member
|
The code change itself is good (less copy-paste, since source of truth for some strings), I'd just reword the change as-is as just factoring out some error-handling functions for number lexing. Then there's also the possibility of unifying the decimal, octal, and hex lexing functions, as I have done in the Rust port. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.