Skip to content

Clarify usage versus encoding of jr and ldh#1875

Merged
Rangi42 merged 2 commits intogbdev:masterfrom
Rangi42:instructions
Dec 11, 2025
Merged

Clarify usage versus encoding of jr and ldh#1875
Rangi42 merged 2 commits intogbdev:masterfrom
Rangi42:instructions

Conversation

@Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Dec 11, 2025

Users keep occasionally getting confused by these (and got confused when we documented "JR e8" too before #1032, so there's just no winning here). I hope this is at least sufficient explanation to link such questions to, even if users don't always notice/understand it right away.

@Rangi42 Rangi42 added this to the 1.0.1 milestone Dec 11, 2025
@Rangi42 Rangi42 requested a review from ISSOtm December 11, 2025 21:47
@Rangi42 Rangi42 added the docs This affects the documentation (web-specific issues go to rgbds-www) label Dec 11, 2025
@ISSOtm
Copy link
Member

ISSOtm commented Dec 11, 2025

Perhaps a line can be added at the top, highlighting that this is a documentation of the form of instructions accepted by rgbasm, and that thus it may appear to conflict with documentation of how instructions are actually encoded.

@gbdev gbdev deleted a comment from ISSOtm Dec 11, 2025
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Rangi42 Rangi42 merged commit e08de39 into gbdev:master Dec 11, 2025
24 checks passed
@Rangi42 Rangi42 deleted the instructions branch December 11, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This affects the documentation (web-specific issues go to rgbds-www)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants