Clarify usage versus encoding of jr and ldh#1875
Merged
Rangi42 merged 2 commits intogbdev:masterfrom Dec 11, 2025
Merged
Conversation
Member
|
Perhaps a line can be added at the top, highlighting that this is a documentation of the form of instructions accepted by rgbasm, and that thus it may appear to conflict with documentation of how instructions are actually encoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users keep occasionally getting confused by these (and got confused when we documented "
JR e8" too before #1032, so there's just no winning here). I hope this is at least sufficient explanation to link such questions to, even if users don't always notice/understand it right away.