Refactor FileStackNode::printBacktrace from recursive to iterative#1869
Merged
Rangi42 merged 2 commits intogbdev:masterfrom Dec 6, 2025
Merged
Refactor FileStackNode::printBacktrace from recursive to iterative#1869Rangi42 merged 2 commits intogbdev:masterfrom
FileStackNode::printBacktrace from recursive to iterative#1869Rangi42 merged 2 commits intogbdev:masterfrom
Conversation
This avoids a potential stack overflow for very long backtraces, or for corrupt object files with cyclic backtraces
Contributor
Author
|
I'm fuzzing RGBLINK with this refactoring, as well as a guard against all crashes due to OOM (since we want to investigate crashes due to memory unsafety or other logic bugs, usually from corrupt object files that RGBASM would never output): -int main(int argc, char *argv[]) {
+int tryMain(int argc, char *argv[]) {
...
}
+
+int main(int argc, char *argv[]) {
+ try {
+ return tryMain(argc, argv);
+ } catch (std::bad_alloc const &) {
+ fatal("Out of memory");
+ }
+}(Regarding use of exceptions if this makes it into production, see https://mropert.github.io/2025/12/03/enum_class_error_codes_part3/ -- and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a potential stack overflow for very long backtraces, or for corrupt object files with cyclic backtraces