MDL-79959 repository: Add custom field picker for SSO identification.#2
Open
gbarat87 wants to merge 1 commit intoMOODLE_403_STABLEfrom
Open
MDL-79959 repository: Add custom field picker for SSO identification.#2gbarat87 wants to merge 1 commit intoMOODLE_403_STABLEfrom
gbarat87 wants to merge 1 commit intoMOODLE_403_STABLEfrom
Conversation
gbarat87
force-pushed
the
MDL-79959-403-repo-equella-sso-identification
branch
6 times, most recently
from
9188811 to
9725181
Compare
gbarat87
pushed a commit
that referenced
this pull request
Feb 25, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
gbarat87
pushed a commit
that referenced
this pull request
Feb 25, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
gbarat87
pushed a commit
that referenced
this pull request
Feb 25, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
gbarat87
force-pushed
the
MDL-79959-403-repo-equella-sso-identification
branch
from
9725181 to
0e9be2f
Compare
gbarat87
force-pushed
the
MDL-79959-403-repo-equella-sso-identification
branch
from
0e9be2f to
b9a9077
Compare
gbarat87
force-pushed
the
MDL-79959-403-repo-equella-sso-identification
branch
3 times, most recently
from
3e638c7 to
1f39a39
Compare
gbarat87
force-pushed
the
MDL-79959-403-repo-equella-sso-identification
branch
from
1f39a39 to
fe2a3f6
Compare
gbarat87
pushed a commit
that referenced
this pull request
Jun 17, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
gbarat87
pushed a commit
that referenced
this pull request
Nov 22, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDL-79959 Add custom field picker for SSO identification for MOODLE_403_STABLE