Fix cppcheck warnings, typos, style issues (backport #1227)#1231
Merged
iche033 merged 1 commit intogz-rendering9from Jan 29, 2026
Merged
Fix cppcheck warnings, typos, style issues (backport #1227)#1231iche033 merged 1 commit intogz-rendering9from
iche033 merged 1 commit intogz-rendering9from
Conversation
Reducing CppCheck report size, frequent warnings: * missing override (CI-clang seems also affected by this) * different argument name * variable scope can be reduced * Ogre or containers in standard library most of times use size_t, better to use * Fix typos * In general tried to follow the rule from c++ core guidelines https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final (but changing it in all code could make PR much bigger) Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com> (cherry picked from commit a395a95)
9 tasks
iche033
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
size_t, better to useI'm running CppCheck with
compile_commands.jsonfile which generated bycmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON(and manual path tweak to run scan on host), notmake cppcheckChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #1227 done by Mergify.