Skip to content

mujoco: Optimize WorldForwardStep Output#893

Draft
iche033 wants to merge 1 commit intoiche033/mujoco_get_contactsfrom
iche033/mujoco_forwardstep_output
Draft

mujoco: Optimize WorldForwardStep Output#893
iche033 wants to merge 1 commit intoiche033/mujoco_get_contactsfrom
iche033/mujoco_forwardstep_output

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Mar 10, 2026

🎉 New feature

Addresses #299
Depends on:

Summary

Updated mujoco's WorldForwardStep implementation to write ChangedWorldPoses to ForwardStep::Output. Previously it was writing all link poses instead of only ones that have changed.

Note that one difference with the dartsim plugin is that in mujoco I loop through all the worlds and track previous link poses for each world. So the prevLinkPoses variable is now stored in WorldInfo struct. Technically it's not necessary since we only support one world at the moment.

Test it

ctest -R simulation_features_mujoco

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the feature
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Ian Chen <iche@intrinsic.ai>
@iche033 iche033 requested review from azeey and scpeters as code owners March 10, 2026 01:22
@iche033 iche033 marked this pull request as draft March 10, 2026 01:22
@iche033 iche033 added the mujoco label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

1 participant