Fix: Bullet featherstone error with double precision bullet#878
Open
silverducks143 wants to merge 1 commit intogazebosim:gz-physics9from
Open
Fix: Bullet featherstone error with double precision bullet#878silverducks143 wants to merge 1 commit intogazebosim:gz-physics9from
silverducks143 wants to merge 1 commit intogazebosim:gz-physics9from
Conversation
bullet-featherstone plugin pulls single precision versions of bullet symbols even if bullet is compiled with double precision. This patch introduces a bullet precision check and sets BT_USE_DOUBLE_PRECISION accordingly. Signed-off-by: Pavel Petrykin <silverducks@altlinux.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bullet-featherstone plugin pulls single precision versions of bullet symbols even if bullet is compiled with double precision. This patch introduces a bullet precision check and sets BT_USE_DOUBLE_PRECISION accordingly.
🦟 Bug fix
Fixes #877
Summary
Expected behavior:
gz-physics builds correctly with both single and double precision bullet.
Actual behavior:
bullet-featherstone plugin pulls single precision bullet symbols, even if bullet is compiled with double precision. This doesn't cause a build failure, but it was caught by verify-elf checker.
Steps to reproduce
Build gz-physics with double precision bullet.
CMake options:
-GNinja
-Wno-dev
-DBUILD_TESTING=ON
Fix consists of an additional check in main CMakeLists.txt, that sets BT_USE_DOUBLE_PRECISION if bullet is double precision.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.