Skip to content

Fix: Bullet featherstone error with double precision bullet#878

Open
silverducks143 wants to merge 1 commit intogazebosim:gz-physics9from
silverducks143:fix-bullet-featherstone-double-precision
Open

Fix: Bullet featherstone error with double precision bullet#878
silverducks143 wants to merge 1 commit intogazebosim:gz-physics9from
silverducks143:fix-bullet-featherstone-double-precision

Conversation

@silverducks143
Copy link

bullet-featherstone plugin pulls single precision versions of bullet symbols even if bullet is compiled with double precision. This patch introduces a bullet precision check and sets BT_USE_DOUBLE_PRECISION accordingly.

🦟 Bug fix

Fixes #877

Summary

  • Expected behavior:
    gz-physics builds correctly with both single and double precision bullet.

  • Actual behavior:
    bullet-featherstone plugin pulls single precision bullet symbols, even if bullet is compiled with double precision. This doesn't cause a build failure, but it was caught by verify-elf checker.

  • Steps to reproduce
    Build gz-physics with double precision bullet.
    CMake options:
    -GNinja
    -Wno-dev
    -DBUILD_TESTING=ON

Fix consists of an additional check in main CMakeLists.txt, that sets BT_USE_DOUBLE_PRECISION if bullet is double precision.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

bullet-featherstone plugin pulls single precision versions of bullet symbols
even if bullet is compiled with double precision. This patch introduces a bullet
precision check and sets BT_USE_DOUBLE_PRECISION accordingly.

Signed-off-by: Pavel Petrykin <silverducks@altlinux.org>
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Feb 18, 2026
@iche033 iche033 added the Bullet Bullet engine label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bullet Bullet engine 🪵 jetty Gazebo Jetty

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

bullet-featherstone plugin pulling wrong symbols when compiled with double precision bullet.

2 participants