Skip to content

Add a Doxygen filter for .h files (backport #523)#527

Merged
j-rivero merged 2 commits intoign-cmake2from
mergify/bp/ign-cmake2/pr-523
Feb 11, 2026
Merged

Add a Doxygen filter for .h files (backport #523)#527
j-rivero merged 2 commits intoign-cmake2from
mergify/bp/ign-cmake2/pr-523

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 6, 2026

🦟 Bug fix

Summary

Doxygen can not parse the GZ_DEPRECATED() macro in a .h file because the existing filter pattern was only applied to *.hh files, not *.h files.

Here's an example without this patch:

Screenshot from 2026-02-06 15-40-04

And with this patch:

Screenshot from 2026-02-06 15-42-42

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #523 done by Mergify.

Signed-off-by: Carlos Aguero <caguero@osrfoundation.org>
(cherry picked from commit 8e87733)

# Conflicts:
#	doc/doxygen/api.in
@mergify mergify bot requested a review from j-rivero as a code owner February 6, 2026 21:41
@mergify mergify bot added the conflicts label Feb 6, 2026
@mergify mergify bot requested a review from scpeters as a code owner February 6, 2026 21:41
@mergify
Copy link
Contributor Author

mergify bot commented Feb 6, 2026

Cherry-pick of 8e87733 has failed:

On branch mergify/bp/ign-cmake2/pr-523
Your branch is up to date with 'origin/ign-cmake2'.

You are currently cherry-picking commit 8e87733.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/doxygen/api.in

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Feb 6, 2026
9 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 6, 2026
Signed-off-by: Carlos Aguero <caguero@osrfoundation.org>
@caguero caguero removed the conflicts label Feb 10, 2026
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Feb 11, 2026
@j-rivero j-rivero merged commit 4deb840 into ign-cmake2 Feb 11, 2026
7 checks passed
@j-rivero j-rivero deleted the mergify/bp/ign-cmake2/pr-523 branch February 11, 2026 10:39
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants