Tentative fix for FindOptiX.cmake#472
Draft
roncapat wants to merge 1 commit intogazebosim:gz-cmake4from
Draft
Conversation
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Contributor
|
Thanks for the PR ! Are you interested into having the support in place even the rendering code can be broken with current versions? Looking into the code: Should be getting th OPTIX_INSTALL_DIR enviroment variable and put that in the correct place. In the worst case, I'm fine if we change all the ocurrences from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lost some hours to fix
gz_renderingbuild warnings about missing dependencyOptiXonly to find out in gazebosim/gz-rendering#1010 that basically that renderer is ancient/broken... nevertheless, I think it would be good to leave here the bit and bolts that I discovered to be issue in my setup forOptiXdiscovery.First of all, on Ubuntu 22.04 the library name is
libnvoptix.so.1while this script currently searches forliboptix.soorliboptix.1.so, so the lookup would always fail IMHO.Secondly, but it can be my fault, I tried setting:
--cmake-args OPTIX_INSTALL_DIR=path--cmake-args OptiX_INSTALL_DIR=pathOPTIX_INSTALL_DIR=pathbut the include files were never detected. I solved the hard way by directly checking the
$envvar infind_pathcall.