Run a CI job linting/parsing the CMake files in cmake/*

[j-rivero]

🎉 New feature

Summary

There is no current check on very broken CMake syntax in our cmake modules (see #221 as an example). Looking for some tools I found cmakelang that provides a parser and linter that was able to find parsing problems on the error present in #221.

The tool is not perfect and sometimes just crash on the presence of errors but serves well as smoke testing. It also brings all kind of conventions that is some nice to have and define in the ign-cmake project.

The PR consists in two parts:

• Setup a github action and a cmakelang configuration file to enable CI on the cmake/* files.
• Apply all kind of fixes to current files that do not alter the behavior or API provided.

Still a Draft until I finish with other PRs affecting OGRE2. We need to include documentation about what conventions we want to follow.

Test it

The github action should take care of test the whole setup.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[mjcarroll]

This looks great. What are next steps to getting in landed? Addressing the remaining outstanding issues?

[j-rivero]

This looks great. What are next steps to getting in landed? Addressing the remaining outstanding issues?

I think so yes.