Fix wrong fields and invalid where params #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natsuke
changed the title
Wrong fields: - In `queryNonDeleted`: replace _isDeleted by [_isDeleted] Query params: - Only check if query.where is defined but not if it’s filled
Natsuke
force-pushed
the
fix/invalid-fields-and-query-params
branch
from
f077745 to
0fb75f3
Compare
Natsuke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Just fall into some issues using this module on a team project.
Basicaly, if we change the name of the
_isDeletedproperty, it is not replicated in thequeryNonDeletedwhere param.Also, in some case we can send query with empty where object, and this was merged with the
queryNonDeletedparam which cause SQL issue.Feel free to discuss if you want something to be changed ! 👍