Skip to content

Error handling on course microservice #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanvaridiksha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Error handling on course microservice #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 140 additions & 12 deletions Course_Instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,32 @@ router.route('/course')

// create a new course (accessed at POST http://localhost:16390/api/course)
.post(function(req, res) {
course.addCourse(req);

res.json({message : 'Course added!'});
course.addCourse(req, res, handleResult);
function handleResult(response)
{
console.log('Callback received');
console.log("Status code " +response.statusCode);
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Course added!'});

}

else if(response.statusCode == 500){
console.log('500');
res.status(500);
res.json({ message: 'Internal Server Error!'});

}
else if(response.statusCode == 409){
console.log('409');
res.status(409);
res.json({ message: 'Course already exists.'});

}
}


});

Expand All @@ -77,27 +100,108 @@ router.route('/course/:course_id')
console.log("Request handled");
}// Logic to show course details
})

// update the student with this id (accessed at PUT http://localhost:16390/api/course/:course_id)
.put(function(req, res) {
//Logic to upadte student details
course.updateCourse(req);
res.json({ message: 'Course updated!' });
course.updateCourse(req, res, handleResult);
function handleResult(response)
{
console.log('Callback received');
console.log("Status code " +response.statusCode);
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Course updated!'});

}

else if(response.statusCode == 500){
console.log('500');
res.status(500);
res.json({ message: 'Internal Server Error!'});

}
else if(response.statusCode == 400){
console.log('400');
res.status(400);
res.json({ message: 'Bad request. Please check body parameters.'});

}
else if(response.statusCode == 417){
console.log('417');
res.status(417);
res.json({ message: 'Updating a course that does not exist'});

}

}


})
.delete(function(req, res) {
//Logic to upadte student details

course.deleteCourse(req);
res.json({ message: 'Course deleted!' });
course.deleteCourse(req, res, handleResult);
function handleResult(response)
{
console.log('Callback received');
console.log(response);
console.log("Status code " +response.statusCode);
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Successfully deleted course'});

}

else if(response.statusCode == 500){
console.log('500');
res.status(500);
res.json({ message: 'Internal Server Error!'});

}
else if(response.statusCode == 417){
console.log('417');
res.status(417);
res.json({ message: 'Expectation Failed. Deleting a course that does not exist'});

}
}

});


router.route('/course/:course_id/student')

.post(function(req, res) {
course.addStudentToCourse(req);
res.json({ message: 'Added Student to Course'})
course.addStudentToCourse(req,res,handleResult);
function handleResult(response)
{
console.log('Callback received');
console.log(response);
console.log("Status code " +response.statusCode);
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Course added!'});

}

else if(response.statusCode == 500){
console.log('500');
res.status(500);
res.json({ message: 'Internal Server Error!'});

}
else if(response.statusCode == 417){
console.log('417');
res.status(417);
res.json({ message: 'Expectation Failed. Adding Student to Course that does not exist.'});

}
}

});

//API end point to get student details (accessed at POST http://localhost:8080/api/student/id)
Expand All @@ -107,12 +211,36 @@ router.route('/course/:course_id/student')
// get the student with that id (accessed at GET http://localhost:8080/api/student/:student_id)
.delete(function(req, res) {

course.deleteStudentFromCourse(req);
res.json({ message: 'Student deleted from course'});
course.deleteStudentFromCourse(req,res,handleResult);
function handleResult(response)
{
console.log('Callback received');
console.log(response);
console.log("Status code " +response.statusCode);
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Course updated!'});

}

else if(response.statusCode == 500){
console.log('500');
res.status(500);
res.json({ message: 'Internal Server Error!'});

}
else if(response.statusCode == 417){
console.log('417');
res.status(417);
res.json({ message: 'Expectation Failed. Invalid operation'});

}
}

});

// Listening for RI scenes
Listening for RI scenes
var subscriber = redis.createClient(6379, 'localhost' , {no_ready_check: true});
subscriber.on('connect', function() {
console.log('Connected to Subscriber Redis');
Expand Down
4 changes: 2 additions & 2 deletions Student_Instance1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ router.route('/student')
if(response.statusCode == 200){
console.log('200');
res.status(200);
res.json({ message: 'Student updated!'});
res.json({ message: 'Student added!'});

}

Expand Down Expand Up @@ -208,7 +208,7 @@ router.route('/student/:student_id/course')
else if(response.statusCode == 417){
console.log('417');
res.status(417);
res.json({ message: 'Expectation Failed. Adding Course to Student that does not exist.'});
res.json({ message: 'Expectation Failed. Invalid Operation.'});

}
}
Expand Down
2 changes: 1 addition & 1 deletion course.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions student.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ if(rowCount == 0)
{
var query = client.query("insert into ms_student_course_tbl values($1, $2)", [lname,courseno], function(err)
{

if(err)
{
console.log('Trying to add course to a student that does not exist');
Expand Down Expand Up @@ -223,7 +222,7 @@ exports.deleteStudent = function(req, res, callback)



exports.deleteCourseFromStudent = function(req,res,callback)
exports.deleteCourseFromStudent = function(req)
{

var courseno = req.params.course_id;
Expand Down