Skip to content

dcache update + collaborative decoders#422

Merged
ninaiiad merged 1 commit intodevelopfrom
ng/dcache-update
Mar 18, 2026
Merged

dcache update + collaborative decoders#422
ninaiiad merged 1 commit intodevelopfrom
ng/dcache-update

Conversation

@ninaiiad
Copy link
Collaborator

@ninaiiad ninaiiad commented Mar 17, 2026

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

);
}
DCacheRead::SpedPast => {
tracing::error!("submissions consumer got sped past");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the NewBidSubmission message and the payload kept in the DCache? or is the NewBidSubmission message sent separately on a spine queue? Wondering if enough information could be included in the spine message to allow a response message to be sent in this case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the payload is in the dcache, so the message in the spine queue is sufficient for a response even if dcache payload is lost
this error, however, means that the message in the spine queue was overwritten too

@ninaiiad ninaiiad merged commit 3f2bed2 into develop Mar 18, 2026
3 checks passed
@ninaiiad ninaiiad deleted the ng/dcache-update branch March 18, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants