mv sim to tile and add ssz support to simulator#415
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
crates/relay/src/auctioneer/types.rs
Outdated
| pub version: SubmissionVersion, | ||
| pub withdrawals_root: B256, | ||
| pub trace: SubmissionTrace, | ||
| /// Decompressed bytes to forward verbatim to the simulator, avoiding re-encoding. |
There was a problem hiding this comment.
is it important that these are decompressed already? also, titan sends bids without compression so for them we can save a reference into the dcache here instead of copying out the bytes
There was a problem hiding this comment.
Agreed - in the case where the bytes can be forwarded as is, a reference to the network bytes can be used?
There was a problem hiding this comment.
Yeah it's unfortunate that some submissions are compressed. I did initially have it send the network bytes direct to the simulator but then later changed my mind. The simulator had to perform the same full decode process as the relay which just felt like too big a change for one PR. It's still my goal though.
|
Looks good - a comment on the overall design: could we not just forward all received bytes to the simulator nodes? Maybe as a future iteration of this? |
Yeah that's what I initially implemented last week but then changed my mind. It just felt like too big a change to do in one go. I wanted to make sure that the existing path would still work as is with current infra. I want to get this merged and deployed. Test it. And move the remaining geths to reths in production and so on before rolling out full change. |
crates/simulator/src/ssz_server.rs
Outdated
| match api.validate_builder_submission_v5(ext).await { | ||
| Ok(()) => StatusCode::OK.into_response(), | ||
| Err(e) => (StatusCode::BAD_REQUEST, e.message().to_string()).into_response(), | ||
| } |
There was a problem hiding this comment.
🟡 SSZ server returns HTTP 400 for internal simulator errors, preventing temporary error classification
The SSZ validation server handler returns StatusCode::BAD_REQUEST (400) for all errors from validate_builder_submission_v5, including internal server errors like ProviderError, GetParentError, etc. On the relay client side (crates/relay/src/simulator/client.rs:126-131), HTTP 400 maps to BlockSimError::BlockValidationFailed, which is is_demotable() == true. In contrast, the _ => branch maps any non-200/400/424 status (e.g., 500) to BlockSimError::RpcError, which is is_temporary() == true and thus not demotable. This means internal simulator errors that should be transient (and should NOT trigger builder demotion) will instead be treated as permanent validation failures. While the old JSON-RPC path had a similar limitation (JSON-RPC errors are all in HTTP 200 bodies), the SSZ path has the HTTP status code mechanism available and should use it to properly classify errors.
Was this helpful? React with 👍 or 👎 to provide feedback.
| } | ||
|
|
||
| fn handle_sim_request(&mut self, req: crate::simulator::ValidationRequest, fast_track: bool) { | ||
| assert_eq!(req.bid_slot, self.last_bid_slot); |
There was a problem hiding this comment.
should this be an assert? maybe just an error log? unless we expect this to have been filtered out earlier?
There was a problem hiding this comment.
Yeah this came from the sim manager. I think it's never supposed to happen. Should be caught earlier unless there's a critical bug in the code.
Having said that I think it has happened on mainnet and we have a ticket open to look into it at some point.
3 participants
Uh oh!
There was an error while loading. Please reload this page.