add support for raw tcp stream with no predefined framing#50
add support for raw tcp stream with no predefined framing#50
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Can you add some info about the motivation here? what is this trying to solve |
The current stream is very limited. It can only be used for custom protocols that follow the framing we've baked in. I want to use it for the handful of requests we make in the housekeeper so that I can drop the tokio part and make it a proper tile, but we can also use it in other similar contexts. It just provides a lot more flexibility for anyone that want's to use flux. |
|
cool makes sense. @louisponet could you please take a look? |
|
Did you vibe some e2e test for this? |
No. I'll fix this up and add tests. |
| /// Read available bytes into rx_buf, returning everything received. | ||
| /// | ||
| /// Loops until WouldBlock. If the buffer fills, returns what was read so | ||
| /// far — mio will re-fire a readable event while kernel data remains. |
There was a problem hiding this comment.
doesnt' this conficlit with the comment belwo
3 participants
Uh oh!
There was an error while loading. Please reload this page.