make theme compatible to gatsby-plugin-mdx v4#174
Open
EricCote wants to merge 1 commit intogatsbyjs:masterfrom
Open
make theme compatible to gatsby-plugin-mdx v4#174EricCote wants to merge 1 commit intogatsbyjs:masterfrom
EricCote wants to merge 1 commit intogatsbyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will solve #172.
I've also updated to React 18.
This is far from perfect. There issues with themes and Gatsby that are difficult to solve.
For now, themes cannot be compatible with the new "Head API". See gatsbyjs/gatsby#35841 (reply in thread) . Result: we need to stick with Helmet until v5 of Gatsby.
I hope that v5 of Gatsby has a better i18n story.