fix: skip Mdx nodes without absolute file path#137
Open
asterikx wants to merge 1 commit intogatsbyjs:masterfrom
Open
fix: skip Mdx nodes without absolute file path#137asterikx wants to merge 1 commit intogatsbyjs:masterfrom
asterikx wants to merge 1 commit intogatsbyjs:masterfrom
Conversation
Plugins such as `gatsby-source-contentful` also create nodes with internal type `Mdx`, but do not add an absolute file path. Skipping Mdx nodes without absolute file path (from which we can derive the locale) seems ok since Contentful already handles localization.
paiou
approved these changes
Sep 6, 2021
paiou
left a comment
paiou
left a comment
There was a problem hiding this comment.
LGTM. Mandatory fix for many source plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins such as
gatsby-source-contentfulalso create nodes with internal typeMdx, but do not add an absolute file path. Skipping Mdx nodes without absolute file path (from which we can derive the locale) seems ok since Contentful already handles localization.