feat(theme-i18n) Allow localization of a subset of pages for individual locales#133
Open
olivier-lacroix wants to merge 4 commits intogatsbyjs:masterfrom
Open
feat(theme-i18n) Allow localization of a subset of pages for individual locales#133olivier-lacroix wants to merge 4 commits intogatsbyjs:masterfrom
olivier-lacroix wants to merge 4 commits intogatsbyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes #128
pagesparameter for each locale allows to limit generation of localized pages by providing an array of RexExp stringslocalizedPath(LocalizedRouterandLocalizedLinkas well) falls back to defaultLang when pointing to a page that has not been localized in the locale.LocalizedLinkwill only fall back to defaultLang if language is not explicitly set. This avoids having the active class triggered in a language switcher for instance.Some further thoughts/options:
node-match-path.fallbackprop onLocalizedLinkinstead of relying on thelanguageprop.