Skip to content

Added support for status hook#275

Merged
gaspardpetit merged 3 commits intomainfrom
feat/added-status-hook
Feb 2, 2026
Merged

Added support for status hook#275
gaspardpetit merged 3 commits intomainfrom
feat/added-status-hook

Conversation

@gaspardpetit
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  verbatim
  __init__.py
  config.py
  main.py
  models.py
  status_hook.py 1-55
  status_types.py
  verbatim.py 269, 274-277, 299, 303, 309, 325, 940, 950-955, 981-987, 993-999, 1014-1018, 1031-1032, 1054-1055
  verbatim/transcript
  idprovider.py
  sentences.py
  words.py
  verbatim/voices
  isolation.py
  verbatim/voices/transcribe
  faster_whisper.py
  whispermlx.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb9662a1dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 243 to 248
def __init__(
self,
config: Config,
*,
models=None,
vad_callback: Optional[VadFn] = None,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve positional models arg for Verbatim()

The new * makes models (and other args) keyword-only, which is a breaking API change from the previous Verbatim(config, models) signature. Any external callers that passed a models object positionally will now raise TypeError: takes 2 positional arguments but 3 were given. If this API is meant to be backward-compatible, keep models positional (or add a positional shim) so existing integrations don’t break.

Useful? React with 👍 / 👎.

@gaspardpetit gaspardpetit merged commit de56380 into main Feb 2, 2026
11 checks passed
@gaspardpetit gaspardpetit deleted the feat/added-status-hook branch February 2, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant