Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9662a1dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def __init__( | ||
| self, | ||
| config: Config, | ||
| *, | ||
| models=None, | ||
| vad_callback: Optional[VadFn] = None, |
There was a problem hiding this comment.
Preserve positional models arg for Verbatim()
The new * makes models (and other args) keyword-only, which is a breaking API change from the previous Verbatim(config, models) signature. Any external callers that passed a models object positionally will now raise TypeError: takes 2 positional arguments but 3 were given. If this API is meant to be backward-compatible, keep models positional (or add a positional shim) so existing integrations don’t break.
Useful? React with 👍 / 👎.
No description provided.