fix: validate navigation URLs to prevent SSRF and local resource access#167
Open
xr843 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: validate navigation URLs to prevent SSRF and local resource access#167xr843 wants to merge 1 commit intogarrytan:mainfrom
xr843 wants to merge 1 commit intogarrytan:mainfrom
Conversation
Block file:/data:/javascript: schemes and private/internal IPs (127.0.0.0/8, 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16, 169.254.0.0/16) in goto, newtab, newTab(), and diff commands. The BROWSE_ALLOW_PRIVATE=1 env var bypasses the private-IP check for local development. Closes garrytan#17 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17.
page.goto()calls to prevent SSRF and local resource accesshttp:andhttps:schemes (blocksfile:,data:,javascript:, etc.)127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16,169.254.0.0/16(cloud metadata),0.0.0.0localhosthostnameBROWSE_ALLOW_PRIVATE=1env var to bypass the private-IP check for local developmentChanges
browse/src/url-validation.tsvalidateNavigationUrl()with scheme + private IP checksbrowse/src/write-commands.tspage.goto()ingotocommandbrowse/src/browser-manager.tspage.goto()innewTab()(coversnewtabcommand)browse/src/meta-commands.tsdiffcommandTest plan
browse/test/commands.test.tspass (withBROWSE_ALLOW_PRIVATE=1)gstack-configfailure confirmed onmain(not related)file:///etc/passwdis blocked bygotohttp://169.254.169.254/is blocked bygotoBROWSE_ALLOW_PRIVATE=1allowshttp://127.0.0.1🤖 Generated with Claude Code