⚡ Bolt: optimize USNI fleet merging to O(N+M)#3
Conversation
- Replaces an O(N*M) nested loop algorithm with a Map-based lookup algorithm in `mergeUSNIWithAIS`. - Filters unmatched USNI vessels proactively, shrinking array size for the secondary name matching algorithm and using splice to avoid repetitive checks. - Documented findings in `.jules/bolt.md`. Co-authored-by: garridolecca <10247583+garridolecca@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized the data merging logic in
src/services/usni-fleet.ts(mergeUSNIWithAIS) to use Map-indexed lookups and filtered arrays, reducing algorithmic complexity from O(N*M) to O(N+M).🎯 Why: The previous implementation used nested loops over AIS vessels and USNI fleet entries, which scales poorly and becomes a CPU bottleneck when fleet data is large.
📊 Impact: Significantly reduces CPU overhead during the USNI fleet synchronization cycle by eliminating repetitive data structure traversals and avoiding continuous execution of heavy string transformations (e.g.
toUpperCase,replace).🔬 Measurement: Verify tests run properly via
npm run test:sidecar,npm run test:data, andnpm run typecheck. You can also profile the time taken to executemergeUSNIWithAISwith large inputs.PR created automatically by Jules for task 3013756185528641729 started by @garridolecca