Skip to content

⚡ Bolt: [performance improvement] Optimize jaccardSimilarity memory allocation#10

Open
garridolecca wants to merge 1 commit intomainfrom
bolt/optimize-jaccard-similarity-1421925763801877681
Open

⚡ Bolt: [performance improvement] Optimize jaccardSimilarity memory allocation#10
garridolecca wants to merge 1 commit intomainfrom
bolt/optimize-jaccard-similarity-1421925763801877681

Conversation

@garridolecca
Copy link
Owner

💡 What: Replaced intermediate Set and Array allocations ([...a]) in the jaccardSimilarity utility function with manual iteration and counting. Uses the inclusion-exclusion principle (|A ∪ B| = |A| + |B| - |A ∩ B|) to compute the union size efficiently.

🎯 Why: The jaccardSimilarity function is called within the inner loop of clusterNewsCore, which has an algorithmic complexity of O(N²). The previous implementation allocated multiple new Sets and Arrays per call, causing high memory overhead and triggering frequent garbage collection cycles, which blocked the main thread (or worker) during large news clustering operations.

📊 Impact: Reduces memory allocations in jaccardSimilarity from O(N+M) to O(1). Time complexity is also improved from O(N+M) to O(min(N, M)) by iterating only over the smaller set. This significantly lowers GC pressure during the O(N²) clustering phase.

🔬 Measurement: Verified via npm run typecheck and npm run test:data. The optimization preserves the exact behavior of the original Jaccard similarity calculation while eliminating object allocations in the critical path.


PR created automatically by Jules for task 1421925763801877681 started by @garridolecca

…llocation

* Replaced Set and Array spread allocations with O(1) manual counting
* Uses inclusion-exclusion principle for efficient union size calculation

Co-authored-by: garridolecca <10247583+garridolecca@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant