Run args #438
Open
Run args #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously you had to pass `--` *twice* in order to get it to an underlying executable. This PR fixes that by inlining subparsers. A further advantage of this change is that you can now mix global and local (subcommand-specific) options. It seems like the old behavior was only there for backwards-compatibility reasons (see pcapriotti/optparse-applicative#433 (comment)).
Previously we just tacked on $@ to the end of the shell script. But often this is completely the wrong place for it, and for basically anything that is a proper shell script (e.g. editGarnConfig) rather than single command, makes it impossible to correctly pass arguments down. This PR changes behavior so that you have to explicitly use $@/$*. This is exactly like any bash script, so I don't think it should be too confusing.
soenkehahn
approved these changes
Nov 24, 2023
Contributor
soenkehahn
left a comment
soenkehahn
left a comment
There was a problem hiding this comment.
Yeah, I think this is probably better than the current behavior. Although it's a breaking change and has some downsides, e.g. something like garn.shell("eslint") doesn't allow passing in arguments anymore. Still, I think an improvement.
cc: @alexdavid
Co-authored-by: Sönke Hahn <soenkehahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit shell/run arguments
Previously we just tacked on $@ to the end of the shell script. But often this is completely the wrong place for it, and for basically anything that is a proper shell script (e.g. editGarnConfig) rather than single command, makes it impossible to correctly pass arguments down.
This PR changes behavior so that you have to explicitly use$@/$ *. This is exactly like any bash script, so I don't think it should be too confusing.
Stacked on #437
Fixes #363.