Upgrade Django DNS Server to Python 3 with full Twisted DNS support#13
Draft
Upgrade Django DNS Server to Python 3 with full Twisted DNS support#13
Conversation
Co-authored-by: garncarz <7193375+garncarz@users.noreply.github.com>
Co-authored-by: garncarz <7193375+garncarz@users.noreply.github.com>
Co-authored-by: garncarz <7193375+garncarz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Python 3
Upgrade Django DNS Server to Python 3 with full Twisted DNS support
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR successfully upgrades the Django DNS Server from Python 2.7 to Python 3, addressing the core issue that Twisted's DNS functionality is now fully supported in Python 3.
Key Changes
Python 3 Migration: Updated all Python files to be compatible with Python 3.8+ (tested on Python 3.12), including fixing string/bytes handling in DNS queries and updating import statements.
Django Modernization: Upgraded from Django 1.9 to 5.2.5 with comprehensive compatibility fixes:
django.conf.urls.urltodjango.urls.re_pathMIDDLEWARE_CLASSES→MIDDLEWARE)is_authenticated()→is_authenticated)get_ip→get_client_ip)DNS Functionality: Fixed critical DNS resolution issues where query names (bytes) weren't properly converted to strings for database lookups. The Twisted DNS server now works perfectly on Python 3.
Docker & Deployment: Updated Dockerfile to use
python:3-slimbase image and createdDockerfile.alpinefor memory-efficient Alpine Linux deployments as requested in the issue comments.Testing: All 11 existing tests pass, confirming that DNS resolution, REST API endpoints, and web interface functionality are preserved.
Verification
The upgrade maintains full backward compatibility while enabling modern Python features:
The server can now run on Python 3.8+ with modern Django, providing better performance, security, and long-term maintainability.
Fixes #9.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.