Add comprehensive DNS request logging to debug unhandled errors#12
Draft
Add comprehensive DNS request logging to debug unhandled errors#12
Conversation
Co-authored-by: garncarz <7193375+garncarz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Weird DNS/53 request
Add comprehensive DNS request logging to debug unhandled errors
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses unhandled DNS query errors that were causing server crashes and missing Sentry logging. The issue manifested as:
Problem
"Weird DNS/53 requests" were causing unhandled errors in the DNS query processing pipeline. These errors occurred when malformed or unexpected DNS queries tried to access
query.name.name, leading to AttributeError exceptions that weren't being caught or logged properly, thus missing Sentry reporting.Solution
Enhanced the
Resolver.query()method indns/networking.pywith comprehensive logging and robust error handling:🔍 Comprehensive Request Logging
🛡️ Robust Error Handling
query.name.namewith proper exception handling📋 Example Log Output
Benefits
The implementation ensures that all "weird DNS/53 requests" are captured and handled gracefully while maintaining full compatibility with existing functionality.
Fixes #10.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.