Skip to content

enable read of README.rst without Unicode error in py3 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
topiaruss wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

enable read of README.rst without Unicode error in py3 #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# -*- coding: utf-8 -*-

from kappa import __version__
import codecs
Copy link
Copy Markdown

@monkut monkut Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.open is recommended for python >= 2.6.
I often use, from io import open to assure that python2 is using the python3 compatible open() which includes encoding specification.

https://mail.python.org/pipermail/python-list/2015-March/687124.html

import os

try:
Expand All @@ -11,7 +12,8 @@


def open_file(fname):
return open(os.path.join(os.path.dirname(__file__), fname))
return codecs.open(os.path.join(os.path.dirname(__file__), fname),
encoding='utf-8')


def run_setup():
Expand Down