fix(frontend) performance issues in main menu project selection #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed custom dynamic rendering & scrolling logic Use slide-y-transition to keep project list size stable during transition. This avoids issues with scrolling
grolu
requested review from
holgerkoser,
klocke-io and
petersutter
as code owners
gardener-robot
added
needs/review
|
@holgerkoser, @klocke-io You have pull request review open invite, please check |
petersutter
reviewed
Jan 20, 2026
| } | ||
| watch(selectedProject, project => { | ||
| const namespace = project?.spec?.namespace | ||
| if (!namespace) return |
| const next = router.resolve(target) | ||
| let currentHighlightedIndex = findProjectIndexCaseInsensitive(projectName) | ||
| if (current.fullPath === next.fullPath) return |
| :close-on-content-click="false" | ||
| :offset="[0]" | ||
| content-class="project-menu" | ||
| transition="slide-y-transition" |
| } | ||
| const newHighlightedProject = sortedAndFilteredProjectList.value[currentHighlightedIndex] // eslint-disable-line security/detect-object-injection | ||
| highlightedProjectName.value = newHighlightedProject.metadata.name |
Member
There was a problem hiding this comment.
bug: type in filter value so that no projects will appear in list, like "foo", then use up / down key. This will result in the error
Uncaught TypeError: Cannot read properties of undefined (reading 'metadata') GMainProjectSelection.vue:371:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2701
Special notes for your reviewer:
Release note: