Skip to content

Conversation

@Firemoon777
Copy link

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Documentation
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences: Extend list of banned items with bundles.

Problem

MobArena removes banned items like ender pearls/chests/shulkers box to prevent bad things. But players are able to place some of banned items (ender pearls and ender chests) to bundle and use it during battle. Bundles are introduced in 1.17 and can hold up to stack of items.

Solution

Solution is simple: ban bundles :)

Action

PR is pretty simple, probably no additional complex action required.

@Firemoon777
Copy link
Author

FYI: I also discovered that players with class My-Items can take Crafting Table, Eye of Ender and 8 Obsidians and... Yeah, players can craft and place Ender Chest.

I'm not a fan of banning every single "bad" item, so I decided to cancel BlockPlace events for ender chest placing in my dedicated arena world. Probably restriction of placing Ender Chest in ArenaListener will be a better solution. Let me know if it is ok and suitable fixes for upstream.

@garbagemule
Copy link
Owner

Thanks for the PR! I think it's a good idea to bring the banned items up to speed, but it does seem like an almost never-ending issue with the My Items class. We could perhaps revisit the MobArena Labs experiment where server owners can customize the list of banned (or allowed?) items instead of relying on hardcoded, static values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants