-
Notifications
You must be signed in to change notification settings - Fork 19
Update recog doc and include user-friendly chapter #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 78.55% 71.55% -7.01%
==========================================
Files 43 43
Lines 18281 18398 +117
==========================================
- Hits 14361 13164 -1197
- Misses 3920 5234 +1314 🚀 New features to boost your workflow:
|
|
some general remarks:
|
|
|
||
| Chapter <Ref Chap="recognition"/> describes the generic, recursive procedure | ||
| used for group recognition throughout this package. At the heart of this | ||
| procedure is the definition of <Q>FindHomomorphism</Q> methods, which is also |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@ThomasBreuer currently verification is not implemented. But it definitely should be made possible for the user to control whether verification happens; and also perhaps certain probabilities. |
frankluebeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a welcome improvement of the recog documentation.
I have added a few more comments.
After addressing the current comments this should be merged soon. Of course, it can be further improved any time later.
|
I agree with @frankluebeck: I'd rather merge this sooner than later. Even if there are still TODO comment in there. Once it is merged, follow-up PRs can further improve things. |
I am working on improving the documentation to include a chapter that is particularly directed to people who want to recognise groups with this package and don't have much theoretical background.
It's still WIP but if you have any suggestions, please feel free to comment.