Skip to content

Update return type of Singular's hilb, based on singular version #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamknockillaree merged 1 commit into from
Jan 6, 2026
Merged

Update return type of Singular's hilb, based on singular version #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/HapPrime/gradedalgebra.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,8 +1367,12 @@ if IsPackageMarkedForLoading("singular","0") then
# Singular is using
Ig := Ideal(R, GroebnerBasis(Ideal(R,I)));
# Now get the Hilbert Series
series := SingularInterface("hilb", [Ig, 1, degs], "intvec");

if SingularInterface("int", "system(\"version\")", "int") < 43211 then
Copy link
Member

@fingolfin fingolfin Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 43211 the version where bigintvec was introduced? Or the version hilb switched to returning a bigintvec?

Copy link
Contributor Author

@lgoettgens lgoettgens Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version hilb changed the return type

Copy link
Contributor Author

@lgoettgens lgoettgens Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I try to minimize my time searching through the Singular history, if not urgent enough 😅
I always have the feeling to get completely lost in it

Copy link
Member

@fingolfin fingolfin Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough :-) I was just curious anyway. If it works, it works!

series := SingularInterface("hilb", [Ig, 1, degs], "intvec");
else
series := SingularInterface("hilb", [Ig, 1, degs], "bigintvec");
fi;

# Remove the last one element of the list since that is not part of
# the series (see the Singular help)
Remove(series, Length(series));
Expand Down
Loading