Umbrella (tip) descriptor oriented

[linuskuehnle]

Includes an extension of the already existing operations Umbrella(Tip)DescriptorOfSurface by returning the umbrella descriptors with a common orientation in case the surface is orientable and the checkOrientation argument is true (optional arg, default is true). If checkOrientation is false, the operations skip the orientation process.

Note that since this modifies default behaviour of the mentioned operations on orientable simplicial surface i also had to adjust the examples in the documentation and tst/simplicialsurfaces03.tst line 285 to passing false for checkOrientation:

gap> ud := UmbrellaDescriptorOfSurface(surf, false);

.tst files in /tst are ignored, otherwise i would have commited that change as well.

[MeikeWeiss]

The tests in the /tst directory are generated automatically by the documentation, i.e. the corresponding example in the documentation has to be changed.

[codecov]

Codecov Report

❌ Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.76%. Comparing base (d4fe0ba) to head (f108023).
⚠️ Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
gap/PolygonalComplexes/constructors.gi	94.24%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   70.58%   70.76%   +0.17%     
==========================================
  Files          62       62              
  Lines       17269    17403     +134     
==========================================
+ Hits        12190    12315     +125     
- Misses       5079     5088       +9     

Files with missing lines	Coverage Δ
gap/Library/library.gd	100.00% <ø> (ø)
gap/PolygonalComplexes/constructors.gd	100.00% <100.00%> (ø)
unit_tests/Test_UmbrellaDescriptor.g	100.00% <100.00%> (ø)
gap/PolygonalComplexes/constructors.gi	89.49% <94.24%> (+0.49%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MeikeWeiss]

Really nice, thank you!!

Is it possible to combine some parts of the normal version and the tip version in a common method?

What happens if the vertices of the given surface are not dense, like for example here:
SimplicialSurfaceByUmbrellaDescriptor([(1,2,3),(1,2,4),(1,3,4),,(2,3,4)])? Does the method work for these surfaces?

[linuskuehnle]

What happens if the vertices of the given surface are not dense, like for example here: SimplicialSurfaceByUmbrellaDescriptor([(1,2,3),(1,2,4),(1,3,4),,(2,3,4)])? Does the method work for these surfaces?

Oh i never thought of that. The next commit includes changes that handles this particular case, thanks for pointing out!

[MeikeWeiss]

I have a few more comments, which also apply to the UmbrellaTipDescriptor.

[MeikeWeiss]

Very nice! Thank you!