Skip to content

Conversation

@fingolfin
Copy link
Member

These hacks were needed back when we did not pass around the fields explicitly. But they always were a crutch: they help us to deal with the case where e.g. q = p or q = p^3 ("so the user already took the square root")

Some tests relied on the removed workaround, so adjust those as well.

These hacks were needed back when we did not pass around the fields
explicitly. But they always were a crutch: they help us to deal with
the case where e.g. q = p or q = p^3 ("so the user already took the
square root")

Some tests relied on the removed workaround, so adjust those as well.
@fingolfin fingolfin closed this Dec 18, 2025
@fingolfin fingolfin reopened this Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (1375b8b) to head (dae4073).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   94.51%   94.47%   -0.04%     
==========================================
  Files          14       14              
  Lines        4684     4669      -15     
==========================================
- Hits         4427     4411      -16     
- Misses        257      258       +1     
Files with missing lines Coverage Δ
gap/Forms.gi 87.27% <100.00%> (-0.84%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 08008d1 into main Dec 18, 2025
6 of 9 checks passed
@fingolfin fingolfin deleted the mh/stricter-unitary-field branch December 18, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants