Introduce explicit field argument and reduce reliance on DefaultFieldOfMatrixGroup
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Dec 17, 2025
Comment on lines
+132
to
134
| if IsSquareInt(Size(field)) then | ||
| q := RootInt(Size(field)); | ||
| else |
Member
There was a problem hiding this comment.
This workaround should not be necessary anymore with your changes, right?
Suggested change
| if IsSquareInt(Size(field)) then | |
| q := RootInt(Size(field)); | |
| else | |
| Assert(0, IsSquareInt(Size(field))); # paranoia check | |
| q := RootInt(Size(field)); |
or even better
Suggested change
| if IsSquareInt(Size(field)) then | |
| q := RootInt(Size(field)); | |
| else | |
| Assert(0, IsSquareInt(Size(field))); # paranoia check | |
| q := Characteristic(field) ^ (DegreeOverPrimeField(field)/2) |
fingolfin
reviewed
Dec 17, 2025
Comment on lines
+135
to
136
| q := Size(field); | ||
| fi; |
Member
There was a problem hiding this comment.
Suggested change
| q := Size(field); | |
| fi; |
fingolfin
reviewed
Dec 17, 2025
| if not IsFinite(F) then | ||
| ErrorNoReturn("The base field of <G> must be finite"); | ||
| fi; | ||
| if not IsEvenInt(DegreeOverPrimeField(F)) then |
Member
There was a problem hiding this comment.
Ditto: can probably be replace by an assertion?
fingolfin
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fieldargument to bothConjugateToSesquilinearFormandConjugateToStandardForm.DefaultFieldOfMatrixGroup.DefaultFieldOfMatrixGroup).DefaultFieldOfMatrixGroup.Resolves #132.