Skip to content

Replace a ForAll by manual execution. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markusbaumeister wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace a ForAll by manual execution. #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions gap/AttributeScheduler.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,21 @@ end );
InstallMethod( ComputeProperty,
[ IsAttributeSchedulerGraph, IsFunction, IsObject ],
function( graph, property, object )
local all_names, how_to_compute, i, property_name, possibilities, max, j;
local all_names, how_to_compute, i, property_name, possibilities, max, j,
valid, k;

all_names := NamesOfComponents( graph );

how_to_compute := rec();

# It is slightly faster to keep the following loops separate
for i in all_names do
how_to_compute.( i ) := -1;
od;
for i in [ 1 .. Length( all_names ) ] do
if Tester( VALUE_GLOBAL( all_names[ i ] ) )( object ) then
how_to_compute.( all_names[ i ] ) := 0;

for i in all_names do
if Tester( VALUE_GLOBAL( i ) )( object ) then
how_to_compute.( i ) := 0;
fi;
od;

Expand All @@ -130,11 +132,17 @@ InstallMethod( ComputeProperty,

for j in [ 1 .. Length( possibilities ) ] do

if ForAll( possibilities[ j ], k -> how_to_compute.( k ) > -1 ) then

valid := true;
for k in possibilities[ j ] do
if how_to_compute.( k ) = -1 then
valid := false;
break;
fi;
od;

if valid then
how_to_compute.( all_names[ i ] ) := j;
break;

fi;

od;
Expand Down