Skip to content

シーンファイルの追加#39

Merged
gaotoast merged 7 commits intomainfrom
develop
Feb 24, 2026
Merged

シーンファイルの追加#39
gaotoast merged 7 commits intomainfrom
develop

Conversation

@gaotoast
Copy link
Owner

概要

miniRT の .rt シーンファイルを追加

関連issue

なし

変更点

  • .gitignore
    • AIエージェント関連ファイル(CLAUDE.md, .claude/, .cursor/, .aider*, .copilot/)を除外対象に追加
  • scenes/error/ 配下
    • 各種パラメータのバリデーションを確認するための異常系シーンを追加
      • 色成分の範囲外・非整数・欠損
      • FOV の範囲外・不正値
      • ライト比率の範囲外
      • 法線ベクトルの範囲外・不正値
      • アンビエント/カメラ/ライトの重複・不足・未定義
      • 不正な識別子、拡張子、不正フォーマット など
  • scenes/valid/ 配下
    • レンダリング動作確認用の正常系シーンを追加
      • 単体オブジェクト(sphere, plane, cylinder)
      • 複数オブジェクト混在シーン(mixed, complex)
      • 影の確認用シーン(shadow)
      • 複数シリンダ・球の並びを確認するシーン(cylinders_row, spheres_row)

懸念点

なし

レビュー観点

なし

その他

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive set of miniRT scene files (.rt format) for testing and validation purposes. The PR includes both valid scenes for rendering verification and error scenes for input validation testing, along with updates to .gitignore to exclude AI agent configuration files.

Changes:

  • Added .gitignore entries to exclude AI agent-related files (CLAUDE.md, .claude/, .cursor/, .aider*, .copilot/)
  • Added 8 valid scene files for testing various rendering scenarios (single objects, mixed scenes, shadows, object rows)
  • Added 30+ error scene files for comprehensive validation testing (invalid parameters, missing/duplicate elements, format errors)

Reviewed changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated 9 comments.

File Description
.gitignore Excludes AI agent configuration files from version control
scenes/valid/*.rt Valid scene files testing sphere, plane, cylinder rendering, shadows, and complex multi-object scenes
scenes/error/*.rt Error scene files for validation testing including color range errors, FOV bounds, missing/duplicate elements, invalid identifiers, and format errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- 重複しているシーンを削除
- ファイル名のタイポを修正
@gaotoast gaotoast merged commit e33d772 into main Feb 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants