有効・無効それぞれのシーンファイルを追加

[gaotoast]

概要

正常系・異常系それぞれの.rtファイルを追加

関連issue

#35

変更点

• scenes/に.rtシーンファイルを追加
  • scenes/valid/は有効
  • scenes/error/は無効

懸念点

なし

レビュー観点

なし

その他

[Copilot]

Pull request overview

This pull request adds test scene files (.rt format) for a ray tracer project, organized into valid and error test cases. The changes address issue #35 by creating a comprehensive test suite with both valid rendering scenarios and error cases for validation testing.

Changes:

• Added 5 valid scene files demonstrating basic shapes (sphere, plane, cylinder) and more complex scenes
• Added 33 error scene files covering various validation scenarios (missing elements, invalid values, format errors)
• Updated .gitignore to exclude AI agent-related files and directories

Reviewed changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
scenes/valid/simple.rt	Valid scene with all basic elements (ambient, camera, light, plane, sphere, cylinder)
scenes/valid/many_sphere.rt	Valid scene demonstrating multiple spheres with consistent formatting
scenes/valid/basic_sphere.rt	Minimal valid scene with a single sphere
scenes/valid/basic_plane.rt	Minimal valid scene with a single plane
scenes/valid/basic_cylinder.rt	Minimal valid scene with a single cylinder
scenes/error/wrong_extension.tr	Tests incorrect file extension (.tr instead of .rt)
scenes/error/orientation_vector_is_lower.rt	Tests orientation vector magnitude < -1
scenes/error/orientation_vector_is_greter.rt	Tests orientation vector magnitude > 1 (filename has typo)
scenes/error/no_light.rt	Tests missing light element
scenes/error/no_extension	Tests file with no extension
scenes/error/no_camera.rt	Tests missing camera element
scenes/error/no_ambient.rt	Tests missing ambient element
scenes/error/multi_light.rt	Tests multiple light elements
scenes/error/multi_camera.rt	Tests multiple camera elements
scenes/error/multi_ambient.rt	Tests multiple ambient elements
scenes/error/missing_object.rt	Tests scene with no objects
scenes/error/missing_light.rt	Tests missing light element (duplicate of no_light.rt)
scenes/error/missing_color_value.rt	Tests incomplete color specification
scenes/error/missing_camera.rt	Tests missing camera element (duplicate of no_camera.rt)
scenes/error/missing_ambient.rt	Tests missing ambient element (duplicate of no_ambient.rt)
scenes/error/line_with_only_spaces.rt	Tests empty line validation
scenes/error/light_ration_is_lower.rt	Tests light ratio < 0 (filename has typo)
scenes/error/light_ration_is_greater.rt	Tests light ratio > 1 (filename has typo)
scenes/error/invalid_ratio.rt	Tests ratio value outside valid range
scenes/error/invalid_normal.rt	Tests zero-length normal vector
scenes/error/invalid_identifier.rt	Tests unrecognized element identifier
scenes/error/invalid_fov.rt	Tests FOV value outside valid range
scenes/error/invalid_color.rt	Tests color value > 255
scenes/error/fov_is_lower.rt	Tests FOV < 0
scenes/error/fov_is_greater.rt	Tests FOV > 180
scenes/error/empty.rt	Tests empty file
scenes/error/duplicate_ambient.rt	Tests duplicate ambient elements (duplicate of multi_ambient.rt)
scenes/error/color_is_not_integer.rt	Tests non-integer color value
scenes/error/color_is_lower.rt	Tests color value < 0
scenes/error/color_is_greter_than_intmax.rt	Tests color value at INT_MAX (filename has typo)
scenes/error/color_is_greater.rt	Tests color value > 255
.gitignore	Added AI agent tool exclusions (CLAUDE.md, .claude/, .cursor/, .aider*, .copilot/)

Comments suppressed due to low confidence (8)

scenes/error/orientation_vector_is_greter.rt:1

• The filename contains a spelling error: "greter" should be "greater". This should be renamed to "orientation_vector_is_greater.rt" for consistency with the similar file "light_ration_is_greater.rt".

A 0.2 255,255,255

scenes/error/color_is_greter_than_intmax.rt:1

• The filename contains a spelling error: "greter" should be "greater". This should be renamed to "color_is_greater_than_intmax.rt" for consistency with the similar file "color_is_greater.rt".

A 0.2 255,255,255

scenes/error/light_ration_is_lower.rt:1

• The filename contains a spelling error: "ration" should be "ratio". This should be renamed to "light_ratio_is_lower.rt" for consistency.

A 0.2 255,255,255

scenes/error/light_ration_is_greater.rt:1

• The filename contains a spelling error: "ration" should be "ratio". This should be renamed to "light_ratio_is_greater.rt" for consistency.

A 1.1 255,255,255

scenes/error/no_light.rt:3

• This file tests that "no_light.rt" is invalid, but there's a duplicate file "missing_light.rt" (lines 1-3) that appears to test the same condition - both files are missing the light (L) element. Consider removing one of these duplicate test cases or clarifying the difference if they test different aspects.

A 0.2 255,255,255
C 0,10,0 0,-1,0 60
sp 0,0,0 4 255,255,255

scenes/error/no_camera.rt:3

• This file tests that "no_camera.rt" is invalid, but there's a duplicate file "missing_camera.rt" (lines 1-3) that appears to test the same condition - both files are missing the camera (C) element. Consider removing one of these duplicate test cases or clarifying the difference if they test different aspects.

A 0.2 255,255,255
L 200,200,200 0.8 255,255,255
sp 0,0,0 4 255,255,255

scenes/error/no_ambient.rt:3

• This file tests that "no_ambient.rt" is invalid, but there's a duplicate file "missing_ambient.rt" (lines 1-3) that appears to test the same condition - both files are missing the ambient (A) element. Consider removing one of these duplicate test cases or clarifying the difference if they test different aspects.

C 0,10,0 0,-1,0 60
L 200,200,200 0.8 255,255,255
sp 0,0,0 4 255,255,255

scenes/error/multi_ambient.rt:5

• This file tests that "multi_ambient.rt" is invalid, but there's a duplicate file "duplicate_ambient.rt" (lines 1-5) that appears to test the same condition - both files have two ambient (A) elements. Consider removing one of these duplicate test cases or clarifying the difference if they test different aspects.

A 0.2 255,255,255
A 0.3 255,255,255
C 0,10,0 0,-1,0 60
L 200,200,200 0.8 255,255,255
sp 0,0,0 4 255,255,255

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.