Skip to content

提出用の修正をdevelopへ取り込み#36

Merged
gaotoast merged 9 commits intodevelopfrom
release/submission-1
Feb 23, 2026
Merged

提出用の修正をdevelopへ取り込み#36
gaotoast merged 9 commits intodevelopfrom
release/submission-1

Conversation

@gaotoast
Copy link
Owner

概要

提出用ブランチrelease/submission-1で行った変更をdevelopに取り込むためのPRです。

関連issue

なし

変更点

  • 提出物に不要なファイルを削除
    • docs/配下および‎miniRT_v9_ja.md(日本語subject)を削除
    • scenes/ 配下のサンプル・エラーシーンをすべて削除
    • srcs/debug/ 配下のデバッグ用出力関数を削除
    • Makefile からデバッグ用ソースの参照を削除
  • キー設定の変更(校舎環境対応)
    • config.h に ‎KEY_P / ‎KEY_M を追加
    • FOV・輝度・オブジェクト直径調整のキーを ‎+/- から ‎P/M に変更
    • put_info.c のヘルプ表示文言を ‎P/M に合わせて更新
  • 正規化ベクトル検証用の ‎NORM_EPSILON を追加し、判定に使用するよう変更
  • リーク防止のために‎free_sceneのメモリ解放ロジックを改善
  • その他軽微な修正

懸念点

  • シーンファイル削除により、プログラムの動作確認が大変になってしまうため、将来的には確認用のシーンファイルを再度追加したいです。( .rtファイルを追加したい #35 で対応予定)

レビュー観点

なし

その他

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges submission-ready changes from the release/submission-1 branch into develop. The changes prepare the codebase for submission by removing unnecessary development files, adjusting key bindings for campus environment compatibility, improving memory safety, and refining numerical precision handling for normalized vector validation.

Changes:

  • Removed development-only files (debug utilities, documentation, test scenes) to create a clean submission package
  • Updated key bindings from +/- to P/M for FOV, brightness, and diameter adjustments to accommodate campus keyboard layouts
  • Enhanced memory safety by improving free_scene function to use double pointers and properly set pointers to NULL after freeing
  • Introduced NORM_EPSILON (1e-3) for normalized vector validation to handle real-world input precision while maintaining EPSILON (1e-6) for internal ray tracing calculations

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

Show a summary per file
File Description
srcs/render/render.c Removed TODO comment and debug function call
srcs/put_info.c Updated help text to reflect P/M key bindings instead of +/-
srcs/parsing/validate_values.c Changed to use NORM_EPSILON for normalized vector validation
srcs/parsing/parse.c Updated free_scene calls to use new double pointer signature
srcs/parsing/object_list.c Changed error handling from perror to print_error for consistency
srcs/key_handler.c Updated key handler to use KEY_P/KEY_M instead of KEY_PLUS/KEY_MINUS
srcs/free.c Improved free_scene to take double pointer and set pointer to NULL after freeing
srcs/debug/print_utils.c Deleted debug utility functions
srcs/debug/print_scene.c Deleted debug scene printing functions
srcs/debug/print_objects.c Deleted debug object printing functions
srcs/debug/print_context.c Deleted debug context printing functions
scenes/ (all files) Deleted all test scene files (to be re-added per issue #35)
miniRT_v9_ja.md Deleted Japanese subject document
includes/miniRT.h Updated free_scene signature and removed debug function declarations
includes/config.h Added KEY_P, KEY_M, and NORM_EPSILON definitions; removed duplicate ESC_KEY section
docs/SPECIFICATION.md Deleted specification document
README.md Removed section referencing deleted scene files
Makefile Removed references to deleted debug source files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gaotoast gaotoast merged commit 964c55d into develop Feb 23, 2026
8 checks passed
@gaotoast gaotoast deleted the release/submission-1 branch February 23, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants