Conversation
- ESC_KEYの重複定義を削除
Developブランチの変更をrelease/submission-1へマージ
There was a problem hiding this comment.
Pull request overview
This PR merges submission-ready changes from the release/submission-1 branch into develop. The changes prepare the codebase for submission by removing unnecessary development files, adjusting key bindings for campus environment compatibility, improving memory safety, and refining numerical precision handling for normalized vector validation.
Changes:
- Removed development-only files (debug utilities, documentation, test scenes) to create a clean submission package
- Updated key bindings from +/- to P/M for FOV, brightness, and diameter adjustments to accommodate campus keyboard layouts
- Enhanced memory safety by improving
free_scenefunction to use double pointers and properly set pointers to NULL after freeing - Introduced
NORM_EPSILON(1e-3) for normalized vector validation to handle real-world input precision while maintainingEPSILON(1e-6) for internal ray tracing calculations
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| srcs/render/render.c | Removed TODO comment and debug function call |
| srcs/put_info.c | Updated help text to reflect P/M key bindings instead of +/- |
| srcs/parsing/validate_values.c | Changed to use NORM_EPSILON for normalized vector validation |
| srcs/parsing/parse.c | Updated free_scene calls to use new double pointer signature |
| srcs/parsing/object_list.c | Changed error handling from perror to print_error for consistency |
| srcs/key_handler.c | Updated key handler to use KEY_P/KEY_M instead of KEY_PLUS/KEY_MINUS |
| srcs/free.c | Improved free_scene to take double pointer and set pointer to NULL after freeing |
| srcs/debug/print_utils.c | Deleted debug utility functions |
| srcs/debug/print_scene.c | Deleted debug scene printing functions |
| srcs/debug/print_objects.c | Deleted debug object printing functions |
| srcs/debug/print_context.c | Deleted debug context printing functions |
| scenes/ (all files) | Deleted all test scene files (to be re-added per issue #35) |
| miniRT_v9_ja.md | Deleted Japanese subject document |
| includes/miniRT.h | Updated free_scene signature and removed debug function declarations |
| includes/config.h | Added KEY_P, KEY_M, and NORM_EPSILON definitions; removed duplicate ESC_KEY section |
| docs/SPECIFICATION.md | Deleted specification document |
| README.md | Removed section referencing deleted scene files |
| Makefile | Removed references to deleted debug source files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
提出用ブランチ
release/submission-1で行った変更をdevelopに取り込むためのPRです。関連issue
なし
変更点
docs/配下およびminiRT_v9_ja.md(日本語subject)を削除scenes/配下のサンプル・エラーシーンをすべて削除srcs/debug/配下のデバッグ用出力関数を削除Makefileからデバッグ用ソースの参照を削除config.hに KEY_P/ KEY_Mを追加+/-から P/Mに変更put_info.cのヘルプ表示文言を P/Mに合わせて更新NORM_EPSILONを追加し、判定に使用するよう変更free_sceneのメモリ解放ロジックを改善懸念点
.rtファイルを追加したい #35 で対応予定)レビュー観点
なし
その他