Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modifies the key bindings for adjusting FOV, brightness, and diameter from the + and - keys to P and M keys to accommodate the school environment's keyboard layout.
Changes:
- Added
KEY_PandKEY_Mconstant definitions for both macOS and Linux platforms - Updated key handler logic to use
KEY_PandKEY_Minstead ofKEY_PLUSandKEY_MINUS - Updated all user-facing help text to display the new keybindings (P/M instead of +/-)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| includes/config.h | Added KEY_P and KEY_M definitions for both macOS and Linux platforms |
| srcs/key_handler.c | Updated get_adjust_params function to check for KEY_P and KEY_M instead of KEY_PLUS and KEY_MINUS |
| srcs/put_info.c | Updated help text strings to display "P (Increase), M (Decrease)" instead of "+ (Increase), - (Decrease)" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
校舎環境に合わせて+-キーをP, Mに変更
関連issue
なし
変更点
懸念点
なし
レビュー観点
その他