Skip to content

Feat: round up tokens when repaying #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xDanr merged 2 commits into from
Feb 23, 2025
Merged

Feat: round up tokens when repaying #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0fb18
round up tokens when repaying
0xDanr Feb 23, 2025
f4263fa
check if lptokens0 > lpTokens1
0xDanr Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contracts/strategies/cpmm/base/CPMMBaseLongStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ abstract contract CPMMBaseLongStrategy is BaseLongStrategy, CPMMBaseStrategy {
uint256 lastCFMMInvariant = calcInvariant(address(0), reserves);

uint256 lastCFMMTotalSupply = s.lastCFMMTotalSupply;
uint256 expectedLPTokens = liquidity * lastCFMMTotalSupply / lastCFMMInvariant;
uint256 expectedLPTokens = liquidity * lastCFMMTotalSupply / lastCFMMInvariant + 1;

amounts[0] = expectedLPTokens * reserves[0] / lastCFMMTotalSupply + 1;
amounts[1] = expectedLPTokens * reserves[1] / lastCFMMTotalSupply + 1;
Expand All @@ -62,9 +62,9 @@ abstract contract CPMMBaseLongStrategy is BaseLongStrategy, CPMMBaseStrategy {
uint256 actualLPTokens1 = amounts[1] * lastCFMMTotalSupply / reserves[1];

if(actualLPTokens0 < actualLPTokens1) {
amounts[0] = amounts[1] * reserves[0] / reserves[1];
} else {
amounts[1] = amounts[0] * reserves[1] / reserves[0];
amounts[0] = amounts[1] * reserves[0] / reserves[1] + 1;
} else if(actualLPTokens0 > actualLPTokens1) {
amounts[1] = amounts[0] * reserves[1] / reserves[0] + 1;
}
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gammaswap/v1-implementations",
"version": "1.2.15",
"version": "1.2.16",
"description": "Pool and strategies implementation contracts for GammaSwap V1 protocol",
"homepage": "https://gammaswap.com",
"scripts": {
Expand Down
Loading