Move calculation of size data for string, int, and list types into resolve_types LUA script#47
Open
mbafford wants to merge 1 commit intogamenet:masterfrom
Open
Move calculation of size data for string, int, and list types into resolve_types LUA script#47mbafford wants to merge 1 commit intogamenet:masterfrom
mbafford wants to merge 1 commit intogamenet:masterfrom
Conversation
…solve_types LUA script
Contributor
Author
|
I did not change the behavior for hashtable, ziplist, intset - these are all still calculated when the code iterates over the keys instead of in the Lua script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my test Redis instance (~4 million entries), this resulted in a substantial improvement in run-time, mainly by batching all of the calls into the same block of LUA as the existing resolve_types script.
As point of comparison, this code runs on my current instance in about 5 minutes. I gave up running the unmodified original code after 15 minutes, as the "Processing String patterns" step was only 1% of the way completed.
I did my best to keep the size calculations true to the original code, but I'm not 100% confident I am calculating exactly the same sizes as the original.