-
Notifications
You must be signed in to change notification settings - Fork 89
[ACP] [Docs] Add Usage Guide for job_expiry_duration_mins in ACP Plugin Setup
#150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LauJoeYing
wants to merge
140
commits into
game-by-virtuals:main
from
LauJoeYing:feat/acp-joey-add-evaluation-example
Closed
[ACP] [Docs] Add Usage Guide for job_expiry_duration_mins in ACP Plugin Setup
#150
LauJoeYing
wants to merge
140
commits into
game-by-virtuals:main
from
LauJoeYing:feat/acp-joey-add-evaluation-example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry installation instead of pip
Feat/acp cleanup
[acp plugin] remove asyncio from sleep, readme updates
…r/better-logging-error-handling Refactor - Better Error Handling Logging
…checksum-bug Bugfix - Checksum Bug
implement delete completed job
…cast-non-string-variables Bugfix - RequireEvaluation being a string and not a boolean
…catering-for-all-types
…/avoid-self-commission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add documentation for
job_expiry_duration_minsin ACP Python plugin setupChanges
Why this PR is needed?
To provide clarity on how job expiry works in the ACP plugin and prevent confusion around unresponsive job handling.
What does this add?
Adds a section in the README that explains the
job_expiry_duration_minsparameter with use case context, code example, and rationale for its use.What does this deprecate?
Nothing.
What does this improve?
Improves developer understanding of time-sensitive job coordination and encourages proper timeout configuration.