Skip to content

Fix invalid pointer access in GameTreeRep::Reveal. #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tturocy merged 1 commit into from
Feb 3, 2026
Merged

Fix invalid pointer access in GameTreeRep::Reveal. #751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## [16.5.1] - unreleased

### Fixed
- `Game.reveal` raised a null pointer access exception or dumped core in some cases (#749)


## [16.5.0] - 2026-01-05

### Fixed
Expand Down
10 changes: 4 additions & 6 deletions src/games/gametree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,16 +259,14 @@ void GameTreeRep::RemoveMember(GameInfosetRep *p_infoset, GameNodeRep *p_node)
void GameTreeRep::Reveal(GameInfoset p_atInfoset, GamePlayer p_player)
{
IncrementVersion();
for (auto action : p_atInfoset->GetActions()) {
for (auto infoset : p_player->m_infosets) {
// make copy of members to iterate correctly
// (since the information set may be changed in the process)
for (const auto &action : p_atInfoset->m_actions) {
auto infosets = p_player->m_infosets;
for (const auto &infoset : infosets) {
auto members = infoset->m_members;

// This information set holds all members of information set
// which follow 'action'.
GameInfoset newiset = nullptr;
for (auto &member : members) {
for (const auto &member : members) {
if (action->Precedes(member)) {
if (!newiset) {
newiset = LeaveInfoset(member);
Expand Down