Efficiency improvements for logit_solve on strategic games#738
Merged
Efficiency improvements for logit_solve on strategic games#738
logit_solve on strategic games#738Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a variety of improvements to performance of
logit_solveon strategic games, largely be eliminating unnecessary duplication of calculations and organising calculations more efficiently.This also refactors the computation in advantage of more efficient methods for computing the relevant derivatives of the payoff function more efficiently.
As a benchmark, these changes lead to about a 50% speedup on random-payoff normal form games with 4 players and 10 strategies per player.