Conversation
This makes a number of updates to polynomials: * The component monomials are now stored as a std::vector rather than a Gambit::List. * All iteration over monomials is now iteration rather than index-based lookup (which was linear-time under List) * Algorithm improvements have been made to addition and multiplication of polynomials as well as evaluation at a point. * Revised: PartialDerivative is now valid for general polynomials (previously it was only correct for multinomials) * Revised: Normalisation is now done if the absolute value of the largest coefficient exceeds a threshold (previously it was the value not absolute value, which was surely not intended). * Move operations added to monomial and polynomial. With the exception of the notes above, there should be no changes in behaviour. Some rough benchmarking suggests this package of changes speeds up enumpoly around 30% on some small-to-mid-size games. LeadingCoefficient TranslateOfMono (and adds pow) MonoInNewCoordinates Max value of nonlinear part normalize normalize - norm by absolute value Adds IsZero, IsConstant Use std::vector instead of Array; add explicit move to polynomial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.